[hydrate] Use cached Methodical function to check for mm implementation #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #180 +/- ##
=======================================
Coverage 83.23% 83.23%
=======================================
Files 37 37
Lines 2511 2511
Branches 215 215
=======================================
Hits 2090 2090
Misses 206 206
Partials 215 215 ☔ View full report in Codecov by Sentry. |
camsaul
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
m/effective-primary-method, which was used incan-hydrate-with-strategy?to check if a particular hydration strategy is available for a model, constructs a primary method every time it is invoked. Instead,m/effective-methodwill try to lookup a cached method for the given dispatch value if the mm is a CachedMultiFnImpl (it is by default).Note that caching only works for hits. If the method isn't implemented for a particular dispatch value, Methodical will go through the expensive process of trying to construct a method.